update user count when discord role is removed#648
Open
PeeyushPrashant wants to merge 17 commits intoRealDevSquad:developfrom
Open
update user count when discord role is removed#648PeeyushPrashant wants to merge 17 commits intoRealDevSquad:developfrom
PeeyushPrashant wants to merge 17 commits intoRealDevSquad:developfrom
Conversation
…dashboard into discord_group_count
Ajeyakrishna-k
suggested changes
Dec 19, 2023
Contributor
Ajeyakrishna-k
left a comment
Ajeyakrishna-k
left a comment
There was a problem hiding this comment.
Please add a test to cover this case
Author
|
Done @Ajeyakrishna-k |
Contributor
|
Please add passing test snapshot for the particular test added in the PR. |
skv93-coder
reviewed
Dec 20, 2023
__tests__/groups/group.test.js
Outdated
| await deleteRoleBtn.click(); | ||
|
|
||
| // Now, check the user count | ||
| if (userCount != null) expect(userCount).toBe(userCount - 1); |
Contributor
There was a problem hiding this comment.
Why we need to check for userCount not being null and skip the the assertion.
Author
Tests (even those which were written earlier) are failing in my local environment (dev branch as well ), as I had mentioned to you earlier. Therefore I have not attached it. |
…ant/website-dashboard into discord_group_count
…ant/website-dashboard into discord_group_count
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Date: 16/12/2023
Developer Name: @PeeyushPrashant
Issue Closes #623
What is the change?
document.getElementById method .
Documentation Updated?
Breaking Changes
Development Tested?
Tested in Staging?
Under Feature Flag
Database Changes
Before & After Change Screenshots
screen-capture.4.webm
Test Coverage
Additional Notes
These tests are failing in dev branch as well, it has not happened because of my changes.